Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlP figures implementation #91

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

falquaddoomi
Copy link
Contributor

Description

This PR contains a very work-in-progress implementation of figures 2 and 3 from the InlP paper, https://www.microbiologyresearch.org/docserver/fulltext/mgen/8/7/mgen000828.pdf. The PR
is intended as a starting point, so you don't have to go and find the original code from the papers, but it definitely needs a lot of work! See issue #88 for more details.

Closes #88.

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@falquaddoomi falquaddoomi marked this pull request as draft October 9, 2024 15:45
@valentina-buoro valentina-buoro self-assigned this Oct 13, 2024
@jananiravi jananiravi added enhancement New feature or request dataviz Data visualization labels Oct 20, 2024
@valentina-buoro
Copy link
Collaborator

Hi @epbrenner @jananiravi .

I tried running some files in the job results folder with the figure-generating code, and I'm getting an error Error in plan(strategy = plan, .skip = T) : could not find function "plan" . Searching the code for the plan function gave no results. Pls could you give me a pointer to what may be going on.
The function I ran was inlp_fig2 .

@jananiravi
Copy link
Member

@falquaddoomi @epbrenner could you look into this?

@falquaddoomi
Copy link
Contributor Author

falquaddoomi commented Oct 22, 2024

So, I'm not an R developer, so take this all with a grain of salt. Anyway...

@valentina-buoro, plan is from the future library; it basically tells R how to resolve "futures", functions that can be executed asynchronously (i.e., not in the main thread). Since it's in the future library, adding library(future) somewhere near the top of the file should resolve it.

I'm not sure why you're getting that message, though. The plan() invocation is almost certainly coming from another library, which is why you're not seeing it in the code, but I don't know enough about R to say whether the author of that library is correctly loading future or if that's the user's responsibility.

@jananiravi
Copy link
Member

If we know for sure that we're invoking future::plan() best to call it explicitly to avoid any confusion. @the-mayer are we using future enough to warrant adding it as a dependency (to function imports)? Then even the library call upfront in this script might not be needed.

Thanks for addressing this, @falquaddoomi

@valentina-buoro
Copy link
Collaborator

Thank you @falquaddoomi @jananiravi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataviz Data visualization enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Fix, Implement InlP Figure
3 participants