Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename functions in acc2lin #65

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Rename functions in acc2lin #65

merged 6 commits into from
Oct 8, 2024

Conversation

awasyn
Copy link
Collaborator

@awasyn awasyn commented Oct 7, 2024

Description

What kind of change(s) are included?

  • Bug fix (fixes an issue).
  • Enhancement (updates functions).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

Signed-off-by: Awa Synthia <[email protected]>
@awasyn
Copy link
Collaborator Author

awasyn commented Oct 7, 2024

@the-mayer

Signed-off-by: Awa Synthia <[email protected]>
@awasyn awasyn changed the title defunct functions in acc2lin Rename functions in acc2lin Oct 7, 2024
@the-mayer the-mayer self-requested a review October 8, 2024 13:53
@the-mayer the-mayer self-assigned this Oct 8, 2024
@the-mayer the-mayer linked an issue Oct 8, 2024 that may be closed by this pull request
@the-mayer the-mayer added bug Something isn't working enhancement New feature or request labels Oct 8, 2024
@the-mayer
Copy link
Collaborator

Tagging duplicate functions for later review.

Duplicated functions:

Copy link
Collaborator

@the-mayer the-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, @awasyn!

Minor adjustments added including locating and removing some old docstring tags. Additionally, created an issue for a later.

Merging!

@the-mayer the-mayer merged commit 3d8ec75 into JRaviLab:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the listed function names in R/acc2lin.R
2 participants