-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init #2
base: master
Are you sure you want to change the base?
Init #2
Conversation
pkopka
commented
Jun 6, 2019
- Script calculates image quality statistics
- Test image in iterfile format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked some spelling bugs, but the script seems to work correctly.
|
||
parser.add_option("-i", "--input", | ||
action="store", dest="input", metavar="PATH", type="string", | ||
help="Path out file png") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j-pet-image-reconstruction/image_parameters/image_quality_stats.py
Lines 23 to 28 in 264726c
parser.add_option("-i", "--input", | |
action="store", dest="input", metavar="PATH", type="string", | |
help="Path out file png") | |
parser.add_option("-o", "--out", | |
action="store", dest="output", metavar="PATH", type="string", | |
help="Path input header interfile") |
Param help is mismatched in the parser options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add help
to the parser options
def interfile2array(param): | ||
""" | ||
conveft interfile to numpy array | ||
:param param: dict contens interfile poarametrs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j-pet-image-reconstruction/image_parameters/image_quality_stats.py
Lines 71 to 72 in 264726c
conveft interfile to numpy array | |
:param param: dict contens interfile poarametrs |
conveft -> convert
contens intefile poarametrs -> containing interfile parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
conveft interfile to numpy array | ||
:param param: dict contens interfile poarametrs | ||
:return: | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j-pet-image-reconstruction/image_parameters/image_quality_stats.py
Lines 83 to 88 in 264726c
def txt2array(file_names, pram_dict, filip=False): | |
""" | |
conveft interfile to numpy array | |
:param param: dict contens interfile poarametrs | |
:return: | |
""" |
Not exactly description of this function. This function is never used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function has been removed.
return arr | ||
|
||
|
||
def txt2interfile(file_names, pram_dict, ouput_name='test.v'): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def txt2interfile(file_names, pram_dict, ouput_name='test.v'):
This function is never used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function has been removed.