Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing multiple orders by orderId #1418

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

rxmp
Copy link
Contributor

@rxmp rxmp commented Sep 8, 2024

No description provided.

@JKorf
Copy link
Owner

JKorf commented Sep 9, 2024

Hi, what was the issue with this? According to the docs it should be a long, not a string

@rxmp
Copy link
Contributor Author

rxmp commented Sep 9, 2024

Hello, the API returns 200 OK and does not actually do anything.
When I tried doing it using their postman collections in the same way, it returned missing orderId error.
Replacing long value with string worked.
Also the EditOrderAsync method uses string and works fine.

@JKorf JKorf merged commit b6e6559 into JKorf:master Sep 11, 2024
1 check passed
@JKorf
Copy link
Owner

JKorf commented Sep 11, 2024

Ah, you're right; I validated your fix works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants