Update jQuery plugin so aria-label and aria-labelledby are copied to the search box correctly #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the search box correctly
srook-sterling
force-pushed
the
fix-aria-labels
branch
from
933c294
to
788d033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I ran into where the values of 'aria-label' and 'aria-labelledby' attributes are not copied correctly to the search box, when using the jQuery version of the plugin, instead appearing as "[object Attr]". As far as I can tell, it only affects the jQuery plugin, hence no changes to the proto coffescript file.
This issue was also mentioned in a comment in #37.