Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS] Grammar adjustments and typo fixes, add software package citations #98

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Feb 21, 2024

Changes

  • Fixed a few phrases for small typos, whitespace, and grammar.
  • Added the citations for a few pieces of software mentioned.

General Comments

  • There are a few places where Jupyter notebooks are directly linked to in the body of the text. This can cause problems down-the-line if you wish/need to change the name of a notebook. I would suggest to point to the documentation or to the Zenodo entry for the notebook in question in case that URL needs to change.

Ref: openjournals/joss-reviews#5525

Copy link
Member

@crvernon crvernon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor edit mentioned in-text.

paper/paper.md Outdated Show resolved Hide resolved
@abigailsnyder abigailsnyder merged commit 5d009f2 into JGCRI:main Apr 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants