Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating quiet messaging -- default option set to TRUE upon loading #78

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

jk-brown
Copy link
Collaborator

Making changes to default verbose == TRUE.

If verbose, print message.

If verbose FALSE return nothing (i.e., turns off verbose messaging).

@jk-brown jk-brown requested a review from bpbond February 17, 2024 16:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@97f4392). Click here to learn what that means.

❗ Current head 151c8e4 differs from pull request most recent head bd9c671. Consider uploading reports for the commit bd9c671 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage        ?   85.77%           
=======================================
  Files           ?       14           
  Lines           ?      218           
  Branches        ?        0           
=======================================
  Hits            ?      187           
  Misses          ?       31           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

R/hush.R Outdated
@@ -1,6 +1,6 @@
# Set an option to control whether messages and warning are suppressed.
# Defaults to verbose messaging.
options("matilda.verbose" = FALSE)
options("matilda.verbose" = TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I've never seen quotes used with options. If it's working, cool, but normally I feel like most R coders would write

options(matilda.verbose = TRUE)

@jk-brown jk-brown merged commit 495e95c into main Feb 17, 2024
6 checks passed
@jk-brown jk-brown deleted the enhancement/quiet-messaging branch May 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants