Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Reviewer Comments #12

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Address Reviewer Comments #12

merged 10 commits into from
Jan 9, 2024

Conversation

mengqi-z
Copy link
Collaborator

@mengqi-z mengqi-z commented Jan 9, 2024

This pull request includes the following main updates:

  1. Add "State of the Field" in the paper
  2. Update the paper figure to indicate the unit of Fahrenheit based degree-days (degree-hours)
  3. Add more details in the figure caption
  4. Upload paper.pdf to the paper folder
  5. Add Contributing section in README
  6. Improve documentation for all the functions' arguments
  7. Clarify raw temperature data units by adding the attribute in the output table from helios::read_ncdf
  8. Update unit column in the helios::hdcd output table to indicate it is Fahrenheit-based degree-days/hours

@mengqi-z mengqi-z merged commit 498f41e into main Jan 9, 2024
1 check passed
@mengqi-z mengqi-z mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant