Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code breaking development #756

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Code breaking development #756

wants to merge 1 commit into from

Conversation

kdorheim
Copy link
Contributor

This PR is for recent (post V3.2) developments but introduces major changes, so I wanted to keep it separate from #755 in case we wanted to have the option to do a minor release.

  • Alpha and Volscl impact RF output #745 Change implementation of the volcanic and aerosol scalars; this causes changes in volcanic RF and aerosol RF output otherwise, there are no other model output behavior changes. The code-breaking change from the new ini file structure.

(IMPORTANT NOTE: this PR documentation will need to be updated to reflect merged PRs)

Here we change where the scalers are applied so that the vol, aerosol, and total forcing outputs are updated appropriately. While this PR does not change hector output or behavior between the parameter name change, there are code-breaking changes that have been made to the ini files. The ini files are not backward compatible. 

---------

Co-authored-by: ptrscll <[email protected]>
Copy link

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.1.1 (d931a00).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant