Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable awscli-v2 in ewok-env/jedi-tools-env, update gmao-swell-env (includes PR https://github.com/JCSDA/spack/pull/332) #338

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 5, 2023

Description

  • Bug fix in py-awscrt, adding missing dependencies on cmake (all platforms) and openssl (Linux)
  • Replace awscli with awscli-v2 in ewok-env and jedi-tools-env
  • Bug fixes in gmao-swell-env: simplify dependency trees

This PR includes #332 (cherry-picked), i.e. when it gets closed it will automatically close #332 as completed, too.

Testing

See JCSDA/spack-stack#813

Note that the "CI failure" below is a codecov error with minimal changes that we should ignore.

Issues

See JCSDA/spack-stack#813

…into feature/enable_awscli_v2_update_swell
@climbfuji climbfuji marked this pull request as ready for review October 7, 2023 01:15
@climbfuji climbfuji self-assigned this Oct 9, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Oct 9, 2023
Copy link
Collaborator

@ashley314 ashley314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues, but I am also not familiar with the requirements for the gmao-swell-env. I tested previously for awscli-v2 on my mac with no issues.

Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my learning: the BundlePackage is a spack mechanism for specifying a set of dependencies, requirements, variant's, conflicts, etc. (but no actual build) that are needed for another package/system defined/installed somewhere else. So in this case SWELL is a development system that is not managed by spack, but requires a certain set of packages/versions/etc that are being managed by spack. Am I understanding this correctly? Thanks!

@climbfuji
Copy link
Collaborator Author

Just for my learning: the BundlePackage is a spack mechanism for specifying a set of dependencies, requirements, variant's, conflicts, etc. (but no actual build) that are needed for another package/system defined/installed somewhere else. So in this case SWELL is a development system that is not managed by spack, but requires a certain set of packages/versions/etc that are being managed by spack. Am I understanding this correctly? Thanks!

These virtual envs are convenient for us to define dependencies and to create modules that load whatever is needed for a specific application.

@climbfuji climbfuji force-pushed the feature/enable_awscli_v2_update_swell branch from e2e7137 to 642ff95 Compare October 9, 2023 18:03
… missing build dependencies cmake (for all), openssl (for linux)
@climbfuji climbfuji force-pushed the feature/enable_awscli_v2_update_swell branch from 642ff95 to 9b7c34e Compare October 9, 2023 18:05
@climbfuji climbfuji merged commit 35c3a61 into JCSDA:jcsda_emc_spack_stack Oct 9, 2023
12 of 13 checks passed
@climbfuji climbfuji deleted the feature/enable_awscli_v2_update_swell branch October 9, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants