Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared variant for platform=cray to openssl #327

Merged

Conversation

climbfuji
Copy link
Collaborator

Description

Add shared variant for platform=cray to var/spack/repos/builtin/packages/openssl/package.py.

Issue(s) addressed

This fixes an issue when trying to build packages dependent on openssl, for example curl:

rocess Process-2:
Traceback (most recent call last):
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 1048, in _setup_pkg_and_run
    pkg, dirty=kwargs.get("dirty", False), context=context
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 779, in setup_package
    set_wrapper_variables(pkg, env_mods)
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 522, in set_wrapper_variables
    update_compiler_args_for_dep(dspec)
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 494, in update_compiler_args_for_dep
    dep_link_dirs.extend(query.libs.directories)
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/spec.py", line 1236, in __get__
    value = f()
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/spec.py", line 1225, in <lambda>
    callbacks_chain.append(lambda: getattr(pkg, self.attribute_name))
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/var/spack/repos/builtin/packages/openssl/package.py", line 386, in libs
    )
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/llnl/util/lang.py", line 486, in __getitem__
    return self.dict[key]
KeyError: 'shared'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib64/python3.6/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib64/python3.6/multiprocessing/process.py", line 93, in run
    self._target(*self._args, **self._kwargs)
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 1067, in _setup_pkg_and_run
    package_context = get_package_context(tb)
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/spack/build_environment.py", line 1256, in get_package_context
    func = getattr(obj, tb.tb_frame.f_code.co_name, "")
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/var/spack/repos/builtin/packages/openssl/package.py", line 386, in libs
    )
  File "/lustre/f2/dev/wpo/role.epic/contrib/spack-stack/c4/spack-stack-1.5.0/spack/lib/spack/llnl/util/lang.py", line 486, in __getitem__
    return self.dict[key]
KeyError: 'shared'

Tested on Gaea.

Dependencies

n/a

Impact

n/a

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji self-assigned this Sep 20, 2023
@climbfuji climbfuji added bug Something is not working INFRA JEDI Infrastructure labels Sep 20, 2023
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great- I'll follow up with spack devs at some point to see if we can clean this up.

@climbfuji climbfuji merged commit 8672dc2 into JCSDA:release/1.5.0 Sep 21, 2023
13 checks passed
@climbfuji climbfuji deleted the bugfix/openssl_shared_variant_cray branch September 21, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants