release/1.5.0: bug fix for ESMF: turn off OpenMP for both clang and apple-clang #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiling in a Ubuntu container with the Clang C/C++ compiler and the GNU Fortran compiler leads to the following error:
Apparently, the Fortran linker command is missing the necessary flags to link against the Clang OpenMP library, because
-fopenmp
forgfortran
only includes the GNU OpenMP library automatically.I checked my macOS build and saw that on macOS,
ESMF_OPENMP
is automatically set toOFF
, so I am suggesting to do the same forclanggfortran
on Linux at least for this release. We can think about a better solution for develop if that is preferred.