Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.5.0: always apply Python cray-rpath patch, add missing dependencies for gsi-env, add conflicts for mapl variants #322

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Sep 11, 2023

Description

Testing

Installed and tested on Narwhal, Orion, Hercules, see also JCSDA/spack-stack#770

Issue(s) addressed

Resolves JCSDA/spack-stack#769
Working towards ufs-community/ufs-weather-model#1854

Dependencies

n/a

Impact

All spack-stack-1.5.0 installs

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@climbfuji climbfuji force-pushed the bugfix/release150_python_cray_rpath branch from c87c182 to 79fd79d Compare September 11, 2023 19:09
@climbfuji climbfuji self-assigned this Sep 11, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Sep 11, 2023
@climbfuji climbfuji marked this pull request as ready for review September 11, 2023 20:32
@AlexanderRichert-NOAA
Copy link
Collaborator

@climbfuji for the module-related change you just made, does the revert match with main spack?

@climbfuji
Copy link
Collaborator Author

Yes, reverting the two files back to before the patch (there are additional changes in mainline spack that we don't have yet, but I am not trying to bring those over now).

@climbfuji climbfuji merged commit a4675f0 into JCSDA:release/1.5.0 Sep 12, 2023
13 checks passed
@climbfuji climbfuji deleted the bugfix/release150_python_cray_rpath branch September 12, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants