Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding myst-parser to jedi-tools-env #305

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

ashley314
Copy link
Collaborator

@ashley314 ashley314 commented Aug 18, 2023

Description

myst-parser is needed for Sphinx to build the JEDI documentation

Issue(s) addressed

Resolves JCSDA/spack-stack#234

Dependencies

None

Impact

None

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR

@ashley314
Copy link
Collaborator Author

Successfully tested on my mac.

EIT-L-18153:docs agriffin$ make html
Running Sphinx v5.3.0
making output directory... done
checking bibtex cache... out of date
parsing bibtex file /Users/agriffin/JEDI/jedi-docs/docs/ref/refs.bib... parsed 10 entries
myst v0.18.1: MdParserConfig(commonmark_only=False, gfm_only=False, enable_extensions=[], disable_syntax=[], all_links_external=False, url_schemes=('http', 'https', 'mailto', 'ftp'), ref_domains=None, highlight_code_blocks=True, number_code_blocks=[], title_to_header=False, heading_anchors=None, heading_slug_func=None, footnote_transition=True, words_per_minute=200, sub_delimiters=('{', '}'), linkify_fuzzy_links=True, dmath_allow_labels=True, dmath_allow_space=True, dmath_allow_digits=True, dmath_double_inline=False, update_mathjax=True, mathjax_classes='tex2jax_process|mathjax_process|math|output_area')
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 222 source files that are out of date
updating environment: [new config] 222 added, 0 changed, 0 removed
reading sources... [100%] working-practices/testing                                                                                                          
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [100%] working-practices/testing                                                                                                           
generating indices... genindex done
writing additional pages... search done
copying images... [100%] inside/testing/images/Test_class.png                                                                                                
copying static files... done
copying extra files... done
dumping search index in English (code: en)... done
dumping object inventory... done
build succeeded.

Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@srherbener
Copy link
Collaborator

@climbfuji after merging this PR should we make a corresponding "update the submodule commit hash" in spack-stack or should we just wait for another PR set to sweep this in?

I can do the spack-stack PR if that's what we should do.

Thanks!

@climbfuji
Copy link
Collaborator

@climbfuji after merging this PR should we make a corresponding "update the submodule commit hash" in spack-stack or should we just wait for another PR set to sweep this in?

I can do the spack-stack PR if that's what we should do.

Thanks!

Would be good to have a spack-stack PR before merging to test it, please go ahead if you have time!

@srherbener srherbener merged commit a777881 into JCSDA:jcsda_emc_spack_stack Aug 18, 2023
13 checks passed
@ashley314 ashley314 deleted the feature/add_sphinx branch August 18, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sphinx MyST-parser to spack and the to spack-stack
3 participants