forked from spack/spack
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various version updates for spack-stack-1.5.0 (met, metplus, eckit, fckit, fiat, ecmwf-atlas) #304
Merged
climbfuji
merged 17 commits into
JCSDA:jcsda_emc_spack_stack
from
climbfuji:feature/version_updates_20230817
Aug 23, 2023
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e00c0d1
Add [email protected] and update patch logic
climbfuji a980585
Add [email protected]
climbfuji c0acdb1
Fix black style errors in var/spack/repos/builtin/packages/met/packag…
climbfuji 177502b
Add [email protected]
climbfuji 644280d
Add [email protected] with correct eckit version dependencies
climbfuji 83de7e2
Add [email protected]
climbfuji 47d3555
Add [email protected] with correct versions for dependencies eckit, …
climbfuji 38c3b30
Fix style errors in var/spack/repos/builtin/packages/fckit/package.py
climbfuji 06647e5
Fix style errors in var/spack/repos/builtin/packages/ecmwf-atlas/pack…
climbfuji 3b5a70d
adding myst
ashley314 28fe0d6
style update
ashley314 3c4a9ef
Merge branch 'jcsda_emc_spack_stack' of https://github.com/jcsda/spac…
climbfuji 79b2f23
Fix patch logic in var/spack/repos/builtin/packages/fiat/package.py; …
climbfuji 2a85131
fckit: disable finalize_ddts for [email protected] and newer
climbfuji 6cea250
Merge branch 'jcsda_emc_spack_stack' of https://github.com/jcsda/spac…
climbfuji ba53e56
Version 0.34 of ecmwf-atlas requires a formatting update of the Intel…
climbfuji a3bd118
Update environment variables for [email protected]+
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,16 +20,20 @@ class EcmwfAtlas(CMakePackage): | |
|
||
version("master", branch="master") | ||
version("develop", branch="develop") | ||
version("0.34.0", sha256="48536742cec0bc268695240843ac0e232e2b5142d06b19365688d9ea44dbd9ba") | ||
version("0.33.0", sha256="a91fffe9cecb51c6ee8549cbc20f8279e7b1f67dd90448e6c04c1889281b0600") | ||
version("0.32.1", sha256="3d1a46cb7f50e1a6ae9e7627c158760e132cc9f568152358e5f78460f1aaf01b") | ||
version("0.31.1", sha256="fa9274c74c40c2115b9c6120a7040e357b0c7f37b20b601b684d2a83a479cdfb") | ||
version("0.31.0", sha256="fa4ff8665544b8e19f79d171c540a9ca8bfc4127f52a3c4d4d618a2fe23354d7") | ||
|
||
depends_on("ecbuild", type=("build")) | ||
depends_on("eckit") | ||
depends_on("boost cxxstd=14 visibility=hidden", when="@0.26.0:", type=("build", "run")) | ||
depends_on("eckit@:1.23", when="@:0.33") | ||
depends_on("[email protected]:", when="@0.34:") | ||
depends_on("boost cxxstd=14 visibility=hidden", when="@0.26.0:0.33.99", type=("build", "run")) | ||
depends_on("boost cxxstd=17 visibility=hidden", when="@0.34.0:", type=("build", "run")) | ||
variant("fckit", default=True) | ||
depends_on("fckit", when="+fckit") | ||
depends_on("fckit@:0.10", when="@:0.33 +fckit") | ||
depends_on("[email protected]:", when="@0.34: +fckit") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
depends_on("python") | ||
|
||
patch("clang_include_array.patch", when="%apple-clang") | ||
|
@@ -43,7 +47,7 @@ class EcmwfAtlas(CMakePackage): | |
values=("Debug", "Release", "RelWithDebInfo"), | ||
) | ||
|
||
variant('openmp', default=True, description='Use OpenMP?') | ||
variant("openmp", default=True, description="Use OpenMP?") | ||
depends_on("llvm-openmp", when="+openmp %apple-clang", type=("build", "run")) | ||
variant("shared", default=True) | ||
|
||
|
@@ -61,7 +65,7 @@ class EcmwfAtlas(CMakePackage): | |
|
||
def cmake_args(self): | ||
args = [ | ||
self.define_from_variant('ENABLE_OMP', 'openmp'), | ||
self.define_from_variant("ENABLE_OMP", "openmp"), | ||
self.define_from_variant("ENABLE_FCKIT", "fckit"), | ||
self.define_from_variant("ENABLE_TRANS", "trans"), | ||
self.define_from_variant("ENABLE_EIGEN", "eigen"), | ||
|
@@ -74,8 +78,8 @@ def cmake_args(self): | |
|
||
@when("+fismahigh") | ||
def patch(self): | ||
filter_file("http://www\.ecmwf\.int", "", "cmake/atlas-import.cmake.in") | ||
filter_file("int\.ecmwf", "", "cmake/atlas-import.cmake.in") | ||
filter_file("http://www\.ecmwf\.int", "", "cmake/atlas-import.cmake.in") # noqa: W605 | ||
filter_file("int\.ecmwf", "", "cmake/atlas-import.cmake.in") # noqa: W605 | ||
filter_file('http[^"]+', "", "cmake/atlas_export.cmake") | ||
patterns = [".travis.yml", "tools/install*.sh", "tools/github-sha.sh"] | ||
for pattern in patterns: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
import glob | ||
import os | ||
|
||
from spack import * | ||
from spack.package import * | ||
|
||
|
||
class Fckit(CMakePackage): | ||
|
@@ -16,54 +16,62 @@ class Fckit(CMakePackage): | |
git = "https://github.com/ecmwf/fckit.git" | ||
url = "https://github.com/ecmwf/fckit/archive/0.9.0.tar.gz" | ||
|
||
maintainers('climbfuji') | ||
maintainers("climbfuji") | ||
|
||
version('master', branch='master') | ||
version('develop', branch='develop') | ||
version("master", branch="master") | ||
version("develop", branch="develop") | ||
version("0.11.0", sha256="846f5c369940c0a3d42cd12932f7d6155339e79218d149ebbfdd02e759dc86c5") | ||
version("0.10.1", sha256="9cde04fefa50624bf89068ab793cc2e9437c0cd1c271a41af7d54dbd37c306be") | ||
version("0.10.0", sha256="f16829f63a01cdef5e158ed2a51f6d4200b3fe6dce8f251af158141a1afe482b") | ||
version("0.9.5", sha256="183cd78e66d3283d9e6e8e9888d3145f453690a4509fb701b28d1ac6757db5de") | ||
|
||
depends_on('mpi') | ||
depends_on('python') | ||
depends_on('ecbuild', type=('build')) | ||
depends_on("mpi") | ||
depends_on("python") | ||
depends_on("ecbuild", type=("build")) | ||
|
||
variant('build_type', default='RelWithDebInfo', | ||
description='CMake build type', | ||
values=('Debug', 'Release', 'RelWithDebInfo')) | ||
variant( | ||
"build_type", | ||
default="RelWithDebInfo", | ||
description="CMake build type", | ||
values=("Debug", "Release", "RelWithDebInfo"), | ||
) | ||
|
||
variant('eckit', default=True) | ||
depends_on('eckit+mpi', when='+eckit') | ||
variant("eckit", default=True) | ||
depends_on("eckit@:1.23 +mpi", when="@:0.10 +eckit") | ||
depends_on("[email protected]: +mpi", when="@0.11: +eckit") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as for ecmwf-atlas. Clear cut between versions that ran fine with C++-11 standard and newer versions that require C++-17. |
||
|
||
variant('openmp', default=True, description='Use OpenMP?') | ||
variant("openmp", default=True, description="Use OpenMP?") | ||
depends_on("llvm-openmp", when="+openmp %apple-clang", type=("build", "run")) | ||
variant('shared', default=True) | ||
variant("shared", default=True) | ||
variant("fismahigh", default=False, description="Apply patching for FISMA-high compliance") | ||
variant("finalize_ddts", default="auto", | ||
description="Enable / disable automatic finalization of derived types", | ||
values=("auto", "no", "yes")) | ||
variant( | ||
"finalize_ddts", | ||
default="auto", | ||
description="Enable / disable automatic finalization of derived types", | ||
values=("auto", "no", "yes"), | ||
) | ||
|
||
def cmake_args(self): | ||
args = [ | ||
self.define_from_variant('ENABLE_ECKIT', 'eckit'), | ||
self.define_from_variant('ENABLE_OMP', 'openmp'), | ||
"-DPYTHON_EXECUTABLE:FILEPATH=" + self.spec['python'].command.path, | ||
'-DFYPP_NO_LINE_NUMBERING=ON' | ||
self.define_from_variant("ENABLE_ECKIT", "eckit"), | ||
self.define_from_variant("ENABLE_OMP", "openmp"), | ||
"-DPYTHON_EXECUTABLE:FILEPATH=" + self.spec["python"].command.path, | ||
"-DFYPP_NO_LINE_NUMBERING=ON", | ||
] | ||
|
||
if '~shared' in self.spec: | ||
args.append('-DBUILD_SHARED_LIBS=OFF') | ||
|
||
if 'finalize_ddts=auto' not in self.spec: | ||
args.append(self.define_from_variant('ENABLE_FINAL', 'finalize_ddts')) | ||
if "~shared" in self.spec: | ||
args.append("-DBUILD_SHARED_LIBS=OFF") | ||
|
||
if self.spec.satisfies('%intel') or self.spec.satisfies('%gcc'): | ||
cxxlib = 'stdc++' | ||
elif self.spec.satisfies('%clang') or self.spec.satisfies('%apple-clang'): | ||
cxxlib = 'c++' | ||
if "finalize_ddts=auto" not in self.spec: | ||
args.append(self.define_from_variant("ENABLE_FINAL", "finalize_ddts")) | ||
|
||
if self.spec.satisfies("%intel") or self.spec.satisfies("%gcc"): | ||
cxxlib = "stdc++" | ||
elif self.spec.satisfies("%clang") or self.spec.satisfies("%apple-clang"): | ||
cxxlib = "c++" | ||
else: | ||
raise InstallError("C++ library not configured for compiler") | ||
args.append('-DECBUILD_CXX_IMPLICIT_LINK_LIBRARIES={}'.format(cxxlib)) | ||
args.append("-DECBUILD_CXX_IMPLICIT_LINK_LIBRARIES={}".format(cxxlib)) | ||
|
||
return args | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am creating this clear separation due to the update to C++-17 in eckit 1.24, fckit 0.11, ecmwf-atlas 0.34.