Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional [email protected][email protected] from unified-dev and skylab-dev templates #954

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 16, 2024

Summary

This PR removes the additional [email protected]+[email protected] combination from unified-dev and skylab-dev templates and only keeps [email protected]+[email protected]. We had both versions in [email protected] for the purpose of testing and transitioning to the newer version, but we don't expect to carry forward both (or even more) versions in develop.

I am also sneaking in a tiny documentation update for Discover to note that the external openmpi package built for the GNU stack is available for both [email protected] (currently used) and [email protected] (may start to use in the future).

Testing

  • CI

Applications affected

UFS/GEOS

Systems affected

n/a

Dependencies

n/a

Issue(s) addressed

n/a

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji marked this pull request as ready for review January 17, 2024 21:43
@climbfuji climbfuji self-assigned this Jan 17, 2024
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Jan 17, 2024
Copy link
Collaborator

@ulmononian ulmononian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@climbfuji climbfuji enabled auto-merge (squash) January 18, 2024 18:33
@climbfuji climbfuji merged commit 2e49ac4 into JCSDA:develop Jan 18, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/remove_additional_esmf850_from_templates branch January 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants