For develop: Define variants for metis and add metis to jedi-mpas-env #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
feature/add_metis_to_jedi-mpas-env
branch
from
3cb7dcf
to
add9eb1
Compare
climbfuji
requested review from
ashley314,
svahl991,
ulmononian and
AlexanderRichert-NOAA
climbfuji
changed the title
svahl991
approved these changes
Jan 5, 2024
ulmononian
approved these changes
Jan 5, 2024
ulmononian
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves #915.
Note that I have chosen to use 64bit integers and reals as default variants, because I've run into problems in the past with high-resolution meshes.
Testing
Applications affected
None (only adding a package)
Systems affected
All systems (since jedi-mpas-env is part of unified-env/skylab-env)
Dependencies
Issue(s) addressed
Resolves #915
Checklist