Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mct and cprnc packages #903

Merged
merged 8 commits into from
Dec 18, 2023

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 11, 2023

Summary

This PR updates the submodule pointer for spack for the changes in PR JCSDA/spack#379, which adds a new package mct, cherry-picks package cprnc from spack develop, and adds them to the relevant meta packages (jedi-neptune-env, ufs-weather-model-env).

Testing

Tested on macOS and on Narwhal, plus CI

Applications affected

ufs-weather-model and jedi-neptune

Systems affected

n/a

Dependencies

Issue(s) addressed

Working towards #885
Working towards #845

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji marked this pull request as ready for review December 14, 2023 03:27
@climbfuji climbfuji self-assigned this Dec 14, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Dec 14, 2023
@climbfuji
Copy link
Collaborator Author

@michalakes FYI

@michalakes
Copy link
Collaborator

@michalakes FYI

Awesome, thank you Dom. I will check out the branch and try it out.

@climbfuji
Copy link
Collaborator Author

I have a

@michalakes FYI

Awesome, thank you Dom. I will check out the branch and try it out.

I have a test install on Narwhal if that's useful.

@climbfuji
Copy link
Collaborator Author

@AlexanderRichert-NOAA Do you want to test installing cprnc and mct (as part of the unified environment)?

@climbfuji
Copy link
Collaborator Author

Merging this now, build problems (don't expect any) will be addressed when we roll out spack-stack-1.6.0.

@climbfuji climbfuji merged commit 2fd73da into JCSDA:develop Dec 18, 2023
7 checks passed
@climbfuji climbfuji deleted the feature/add_mct_and_cprnc branch December 18, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants