Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the GitHub CLI to the global workflow env #1416

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

eap
Copy link
Collaborator

@eap eap commented Dec 13, 2024

This change adds the GitHub CLI to the global workflow env. Go language based dependencies don't compile on the intel stack, so some intel-specific config has been added to force the use of an alternate GCC compiler. This change has been tested in GCC and Intel on an Ubuntu 24.04 site config.

Testing

As above, tested in Ubuntu on GCC/Intel

Applications affected

Global Workflow Env.

Systems affected

N/A

Dependencies

None

Issue(s) addressed

Fixes: #1105

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

The intel build fails because it can't build grep. I am pretty sure that we can assume grep is available as an external package on all systems.

@eap
Copy link
Collaborator Author

eap commented Dec 13, 2024

@climbfuji I'm going to fix that anyways; we are observing the same grep issue on our Ubuntu site config (see discussion here - Steve has also verified that he is seeing it).

@eap
Copy link
Collaborator Author

eap commented Dec 13, 2024

Ok, I've added the fix to this PR. No idea why this issue is showing up now but it seems to be affecting many intel builds and the fix is pretty easy.

@eap eap requested a review from climbfuji December 13, 2024 22:24
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked by #1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INSTALL]: GitHub CLI
3 participants