Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up 2 to #1363 (update from spack dev 20241031): fix JEDI CI container builds for gcc and clang, and work towards fixing intel #1381

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 14, 2024

Summary

This PR is a follow up to the update from spack develop in #1363. It removes the external gmake packages so that the new requirement for gmake to be one of 4.2.1 or 4.4.1 can be honored.

Testing

#18 ERROR: process "docker-shell cd /opt/spack-environment && spack env activate . && spack install --fail-fast && spack gc -y" did not complete successfully: exit code: 1
------
 > [builder 6/8] RUN cd /opt/spack-environment && spack env activate . && spack install --fail-fast && spack gc -y:
33.03 ==> Error: failed to concretize `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, ..., `[email protected]` for the following reasons:
33.03      1. rust: Rust not compatible with Intel Classic compilers
33.03      2. rust: Rust not compatible with Intel Classic compilers
33.03         required because conflict is triggered when %intel 
33.03         required because conflict constraint  . You could consider setting `concretizer:unify` to `when_possible` or `false` to allow multiple versions of some packages.

Applications affected

JEDI CI

Systems affected

JEDI CI containers

Dependencies

n/a

Issue(s) addressed

n/a

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Nov 15, 2024
@climbfuji climbfuji changed the title Follow-up 2 to #1363 (update from spack dev 20241031): fix JEDI CI container builds Follow-up 2 to #1363 (update from spack dev 20241031): fix JEDI CI container builds for gcc and clang, and work towards fixing intel Nov 15, 2024
@climbfuji climbfuji marked this pull request as ready for review November 15, 2024 14:48
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Nov 15, 2024
Copy link
Collaborator

@eap eap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix.

@climbfuji
Copy link
Collaborator Author

Thanks for the quick review!

@climbfuji climbfuji merged commit 4bf5913 into develop Nov 15, 2024
7 of 8 checks passed
@climbfuji climbfuji deleted the bugfix/spack_upd_follow_up_containers branch November 15, 2024 16:22
@climbfuji
Copy link
Collaborator Author

Created a follow-up issue for the remaining Intel error: #1383

Copy link

@stiggy87 stiggy87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
Development

Successfully merging this pull request may close these issues.

3 participants