Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NEPTUNE Python dependencies into its their own package neptune-python-env, remove legacy environment variables for NEPTUNE #1343

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 14, 2024

Summary

This PR moves the full NEPTUNE Python dependencies into their own package neptune-python-dev. Only the basic dependencies on f90nml and python-dateutil remain in neptune-env (needed by NUOPC).

The espc variant is turned off by default in neptune-env, but the neptune-dev template enables it. Likewise, the xnrl variant is turned off by default in neptune-python-env, but the neptune-dev template enables it.

Several legacy environment variables for hdf5, libyaml, p4est are removed from configs/common/modules_*.yaml.

Testing

  • Manual testing on @climbfuji's development system blackpearl with gcc in neptune_atmos
  • CI testing in NEPTUNE on Nautilus with Intel classic, Intel llvm, GNU
  • Manual testing on @climbfuji's development system blackpearl with gcc in dsapi
  • Manual testing on @climbfuji's development system blackpearl with gcc in ioapi
  • spack-stack CI (see below)

Applications affected

NEPTUNE, JEDI-NEPTUNE

Systems affected

None

Dependencies

n/a

Issue(s) addressed

Working towards #1342 (for NEPTUNE only)

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Oct 14, 2024
@climbfuji climbfuji added the NAVY United States Naval Research Lab label Oct 14, 2024
@climbfuji climbfuji changed the title Move NEPTUNE Python dependencies into its their own package neptune-python-env Move NEPTUNE Python dependencies into its their own package neptune-python-env, remove legacy environment variables for NEPTUNE Oct 16, 2024
@climbfuji climbfuji marked this pull request as ready for review October 16, 2024 12:04
@climbfuji climbfuji merged commit 2b363ea into JCSDA:develop Oct 16, 2024
8 checks passed
@climbfuji climbfuji deleted the feature/split_neptune_env branch October 16, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NAVY United States Naval Research Lab
Projects
Development

Successfully merging this pull request may close these issues.

3 participants