Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UCX on Narwhal, skip ~/.spack logic for macOS, delete CI workflows on R&D cluster and macOS Intel #1033

Merged
merged 12 commits into from
Mar 20, 2024

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 18, 2024

Summary

  1. Provide instructions for loading Cray UCX module instead of OFI module at runtime on Narwhal for better performance.
  2. Revert node.js workaround on Narwhal. Requires Bug fix for py-jupyter-server and hidden npm/node dependency spack#417. This also fixed the build error reported on macOS.
  3. Skip recent change to ignore ~/.spack on macOS to avoid annoying error messages
  4. Delete CI workflows on JCSDA R&D cluster and macOS Intel (both turned off)
  5. Bug fix in configs/common/modules_*.yaml: need protobuf and py-protobuf modules for cylc-jupyter server to work

Testing

I tested installing [email protected] on my macOS with a broken local npm/node installation (to mimick the problem described in #995. I was able to install it successfully with the default variant ~typescript, and also with +typescript (which added npm and node as dependencies).

It also fixed the problem on Narwhal with the existing but broken npm/node installation.

Also: CI testing with default variant ~typescript.

Applications affected

List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.

Systems affected

List all systems intentionally or unintentionally affected by this PR.

Dependencies

Issue(s) addressed

Resolves #995
Resolves #928
Resolves #1029
Resolves #1018

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji marked this pull request as ready for review March 19, 2024 15:14
@climbfuji climbfuji changed the title WIP - Feature/narwhal ucx etc Use UCX on Narwhal, skip ~/.spack logic for macOS, delete CI workflows on R&D cluster and macOS Intel Mar 19, 2024
@climbfuji climbfuji enabled auto-merge (squash) March 20, 2024 15:29
@climbfuji climbfuji disabled auto-merge March 20, 2024 17:11
@climbfuji climbfuji merged commit b22234c into JCSDA:develop Mar 20, 2024
6 checks passed
@climbfuji climbfuji deleted the feature/narwhal_ucx_etc branch March 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
3 participants