-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use UCX on Narwhal, skip ~/.spack
logic for macOS, delete CI workflows on R&D cluster and macOS Intel
#1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s module in compiler config
climbfuji
force-pushed
the
feature/narwhal_ucx_etc
branch
from
March 19, 2024 14:32
9e936c3
to
0fe0996
Compare
…/macos-ci-x86_64.yaml
climbfuji
changed the title
WIP - Feature/narwhal ucx etc
Use UCX on Narwhal, skip Mar 19, 2024
~/.spack
logic for macOS, delete CI workflows on R&D cluster and macOS Intel
3 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener,
sking112 and
RatkoVasic-NOAA
March 20, 2024 00:00
…uf modules for cylc-jupyter server to work
RatkoVasic-NOAA
approved these changes
Mar 20, 2024
srherbener
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
node.js
workaround on Narwhal. Requires Bug fix for py-jupyter-server and hidden npm/node dependency spack#417. This also fixed the build error reported on macOS.~/.spack
on macOS to avoid annoying error messagesconfigs/common/modules_*.yaml
: needprotobuf
andpy-protobuf
modules forcylc-jupyter
server to workTesting
I tested installing
[email protected]
on my macOS with a broken localnpm
/node
installation (to mimick the problem described in #995. I was able to install it successfully with the default variant~typescript
, and also with+typescript
(which added npm and node as dependencies).It also fixed the problem on Narwhal with the existing but broken
npm
/node
installation.Also: CI testing with default variant
~typescript
.Applications affected
List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.
Systems affected
List all systems intentionally or unintentionally affected by this PR.
Dependencies
Issue(s) addressed
Resolves #995
Resolves #928
Resolves #1029
Resolves #1018
Checklist