Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FMX port]Dotted brush parameters #1135

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[FMX port]Dotted brush parameters #1135

merged 1 commit into from
Oct 27, 2022

Conversation

livius2
Copy link
Contributor

@livius2 livius2 commented Oct 18, 2022

  1. Renamed FDottedBrush to DottedBrushTreeLines
  2. Introduced DottedBrushGridLines. On VCL it is an "alias" for DottedBrushTreeLines. On FMX separate brush.
  3. Added parameters to DrawDottedHLine and DrawDottedVLine virtual methods.

@livius2
[FMX port]Dotted brush parameters
cc904db 
1. Renamed FDottedBrush to DottedBrushTreeLines
2. Introduced DottedBrushGridLines. On VCL it is an "alias" for DottedBrushTreeLines. On FMX separate brush.
@livius2
Copy link
Contributor Author

livius2 commented Oct 24, 2022

If you have any objections, feel free to comment i am open for any suggestions.

@joachimmarder
Copy link
Contributor

Wouldn't it be more consistent, to have also two members for the brushes in VCL as well? That should reduce conditional code for this stuff. See also issue #1134 .

@joachimmarder joachimmarder merged commit a1577e8 into JAM-Software:master Oct 27, 2022
@joachimmarder joachimmarder mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@livius2 @joachimmarder