Split sekiban core into Sekiban.Core.Neutral and Sekiban.Core.AspNetCore #471
Conversation
There was a problem hiding this comment.
@info-miura , Thank you for the great work!
After the consideration with @tkawae , we recommend following project structure.
Rename Sekiban.Core.Neutral -> Sekiban.Core.DotNet - and it will be released as nuget
Rename Sekiban.Core.AspNetCore -> Sekiban.Core - and it will be released as nuget
Remove Sekiban.Core - it is same with Sekiban.Core.AspNetCore now.
In future release, current Sekiban.Pure will be main sekiban, and we will consider naming by then.
Sekiban.Core.AspNetCore -> Sekinban.Core Sekiban.Core.Neutral -> Sekiban.Core.DotNet
|
Moved Some of |
|
| @@ -159,7 +160,8 @@ SekibanCoreServiceExtensions.MultiProjectionType multiProjectionType | |||
| services.AddMediatR( | |||
| new MediatRServiceConfiguration().RegisterServicesFromAssemblies( | |||
| Assembly.GetExecutingAssembly(), | |||
| GetAssembly())); | |||
| GetAssembly(), | |||
| typeof(UpdateNoticeEventSubscriber<>).Assembly)); // Sekiban.Core.DotNet needs to be added | |||
There was a problem hiding this comment.
Sekiban.Core.DotNet のAssemblyが登録されていないため、エラーで落ちていました。追加して、問題がなくなったら許可してマージします。
What type of PR is this? (check all applicable)
Description
This PR splits
Sekiban.CoreintoSekiban.Core.NeutralandSekiban.Core.AspNetCore.Sekiban.Core.Neutralno longer depends onMicrosoft.AspNetCore.App, so it can be used in more restricted configurations.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
[optional] Are there any post deployment tasks we need to perform?
Which implementation of
IUserInformationFactoryshould be used without depending onMicrosoft.AspNetCore.App?[optional] What gif best describes this PR or how it makes you feel?