Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor following intellicode suggestions #207

Merged
merged 45 commits into from
Jan 9, 2024
Merged

Refactor following intellicode suggestions #207

merged 45 commits into from
Jan 9, 2024

Conversation

tkawae
Copy link
Collaborator

@tkawae tkawae commented Jan 8, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The source code was refactored according to IntelliCode suggestions. The following points proposed in the issue #206 have been fixed.

  • CA1822: Mark members as static
  • CA1860: Avoid using 'Enumerable.Any()' extension method
  • Null check can be simplified (IDE0270)

In addition, the following points have also been corrected.

  • CA1841: Prefer Dictionary Contains methods
  • CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) method
  • CA1510: Use ArgumentNullException throw helper
  • Use conditional expression for return (IDE0046)
  • Simplify conditional expression (IDE0075)

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview?tabs=net-8

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: Current test will cover use cases.
  • I need help with writing tests

@tkawae tkawae requested a review from tomohisa January 8, 2024 10:47
@tkawae tkawae linked an issue Jan 8, 2024 that may be closed by this pull request
Refactoring following IntelliCode suggestions #206
Closed
tomohisa
tomohisa previously approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@tomohisa tomohisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

tomohisa and others added 16 commits January 8, 2024 13:46
@tomohisa
fix dynamo duplicated code
926250b
@tomohisa
remove duplicate for Dynamo
4466454
@tomohisa
Update CosmosDocumentRepository.cs
8ca19f0
@tomohisa
Not throwing Exception itself
804b79f
@tomohisa
Refactor for Aggregate
eefe401
@tomohisa
fix minor code issues
dadaa00
@tomohisa
Refactor to remove unnecesarly bool
c5dda2a
@tomohisa
Fix throw new Exception
0a00656
@tomohisa
fix throw new Exception(
717f109
@tkawae
Replace nested ternary operators with switch expression or other equi…
26c94da 
…valents.
@tkawae
Merge branch '206-refactoring-following-intellicode-suggestions' of h…
2c35dbc 
…ttps://github.com/J-Tech-Japan/Sekiban into 206-refactoring-following-intellicode-suggestions
@tkawae
Fix issue pointed out by sonarcloud
b6af7d8
@tomohisa
Update MemoryCacheMultiProjection.cs
e4b2644
@tomohisa
Merge branch '206-refactoring-following-intellicode-suggestions' of h…
89ae644 
…ttps://github.com/J-Tech-Japan/Sekiban into 206-refactoring-following-intellicode-suggestions
@tkawae
CA1829: Use Length/Count property instead of Enumerable.Count method
2512f8f
@tomohisa
Update AggregateTestHelper.cs
65cf29c
tkawae and others added 19 commits January 9, 2024 18:09
@tkawae
CA1825: Avoid zero-length array allocations
95a0b07
@tkawae
CA1822: Mark members as static
6ce1634
@tkawae
Simplify interpolation (IDE0071)
a35b338
@tkawae
Remove unused private member (IDE0051)
3120892
@tkawae
Add readonly modifier (IDE0044)
c970d73
@tkawae
Use switch expression (IDE0066)
8e0b836
@tkawae
Merge branch '206-refactoring-following-intellicode-suggestions' of h…
eb11c43 
…ttps://github.com/J-Tech-Japan/Sekiban into 206-refactoring-following-intellicode-suggestions
@tkawae
CA1869: Cache and reuse 'JsonSerializerOptions' instances
b8dd8e8
@tkawae
CA1860: Avoid using 'Enumerable.Any()' extension method
d0ce36d
@tkawae
Use collection initializers or expressions (IDE0028)
767ce29
@tkawae
Use collection expression for array (IDE0300)
66a447a
@tkawae
Use collection expression for fluent (IDE0305)
3caaf51
@tkawae
Use collection expression for empty (IDE0301)
b395ace
@tkawae
IDE1006 (Naming rule violation)
e2c868c
@tkawae
IDE1006 (Naming rule violation)
f458e9b
@tkawae
IDE1006 (Naming rule violation)
9cb0ceb
@tkawae
xUnit2024 Do not use boolean asserts for simple equality tests
2a1c5ea
@tomohisa
Update AggregateTestHelper.cs
585dcfd
@tomohisa
Merge branch '206-refactoring-following-intellicode-suggestions' of h…
f001825 
…ttps://github.com/J-Tech-Japan/Sekiban into 206-refactoring-following-intellicode-suggestions
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarCloud

@tomohisa
Copy link
Contributor

tomohisa commented Jan 9, 2024

Thanks for the refactoring !

@tomohisa tomohisa merged commit 28905c4 into main Jan 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomohisa tomohisa tomohisa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring following IntelliCode suggestions
2 participants
@tkawae @tomohisa