Consider making utils functions public and potentially add a couple #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @grugnog , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to write a couple of utility functions during a project and was wondering if one or both would be useful to others.
The first is the exact opposite of numberToLetter().
The second parses "sheet?A1:Z5" type references into values than can be looped over to retrieve a subset of the sheet - this is not very generalized (it doesn't handle non-range references, for instance) but was sufficiently useful in my case, which was allowing a configurable input range in a recognizable format.
This PR also renames numberToLetter to NumberToLetter so it is exported and also a utility function (since it was also generally useful).
If there is interest I would be happy to take a pass at function docs and tests. I did a bit of testing for letterToNumber making sure it worked for even large letter combinations (ZZZZ etc), but was working in a separate project and so they would need adapting.