Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[BUG] Added Missing default values for IvyFeatures #3632

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Oct 20, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed added missing default values for Ivy Features.

Risk factors

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove the default value from the feature flag class

@shamim-emon
Copy link
Member Author

Let's also remove the default value from the feature flag class

Done

@ILIYANGERMANOV ILIYANGERMANOV merged commit 71fdaa2 into Ivy-Apps:main Oct 20, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add Default Values For Ivy Features
2 participants