Skip to content

ci: improve binary release workflow #3

ci: improve binary release workflow

ci: improve binary release workflow #3

GitHub Actions / clippy succeeded Mar 23, 2024 in 1s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.78.0-nightly (878c8a2a6 2024-02-29)
  • cargo 1.78.0-nightly (8964c8ccf 2024-02-27)
  • clippy 0.1.78 (878c8a2 2024-02-29)

Annotations

Check warning on line 148 in tuic-client/src/connection/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `MutexGuard` is held across an `await` point

warning: this `MutexGuard` is held across an `await` point
   --> tuic-client/src/connection/mod.rs:148:32
    |
148 |                 let new_conn = ENDPOINT.get().unwrap().lock().connect().await?;
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
   --> tuic-client/src/connection/mod.rs:148:73
    |
148 |                 let new_conn = ENDPOINT.get().unwrap().lock().connect().await?;
    |                                                                         ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock

Check warning on line 134 in tuic-client/src/connection/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `MutexGuard` is held across an `await` point

warning: this `MutexGuard` is held across an `await` point
   --> tuic-client/src/connection/mod.rs:131:13
    |
131 | /             ENDPOINT
132 | |                 .get()
133 | |                 .unwrap()
134 | |                 .lock()
    | |_______________________^
    |
    = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
   --> tuic-client/src/connection/mod.rs:136:18
    |
136 |                 .await
    |                  ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
    = note: `#[warn(clippy::await_holding_lock)]` on by default

Check warning on line 18 in tuic/src/protocol/heartbeat.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you should consider adding a `Default` implementation for `Heartbeat`

warning: you should consider adding a `Default` implementation for `Heartbeat`
  --> tuic/src/protocol/heartbeat.rs:16:5
   |
16 | /     pub const fn new() -> Self {
17 | |         Self
18 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
   = note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
   |
12 + impl Default for Heartbeat {
13 +     fn default() -> Self {
14 +         Self::new()
15 +     }
16 + }
   |