Skip to content

ci: improve binary release workflow #7

ci: improve binary release workflow

ci: improve binary release workflow #7

Triggered via push March 23, 2024 08:00
Status Success
Total duration 53s
Artifacts

build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

5 warnings
this `MutexGuard` is held across an `await` point: tuic-client/src/connection/mod.rs#L148
warning: this `MutexGuard` is held across an `await` point --> tuic-client/src/connection/mod.rs:148:32 | 148 | let new_conn = ENDPOINT.get().unwrap().lock().connect().await?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await note: these are all the `await` points this lock is held through --> tuic-client/src/connection/mod.rs:148:73 | 148 | let new_conn = ENDPOINT.get().unwrap().lock().connect().await?; | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
this `MutexGuard` is held across an `await` point: tuic-client/src/connection/mod.rs#L131
warning: this `MutexGuard` is held across an `await` point --> tuic-client/src/connection/mod.rs:131:13 | 131 | / ENDPOINT 132 | | .get() 133 | | .unwrap() 134 | | .lock() | |_______________________^ | = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await note: these are all the `await` points this lock is held through --> tuic-client/src/connection/mod.rs:136:18 | 136 | .await | ^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock = note: `#[warn(clippy::await_holding_lock)]` on by default
you should consider adding a `Default` implementation for `Heartbeat`: tuic/src/protocol/heartbeat.rs#L16
warning: you should consider adding a `Default` implementation for `Heartbeat` --> tuic/src/protocol/heartbeat.rs:16:5 | 16 | / pub const fn new() -> Self { 17 | | Self 18 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 12 + impl Default for Heartbeat { 13 + fn default() -> Self { 14 + Self::new() 15 + } 16 + } |
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/