Skip to content

Commit

Permalink
Remove mongodb port mapping
Browse files Browse the repository at this point in the history
Test suite no longer needs a “real” mongodb instance
  • Loading branch information
mattlubner committed Jun 4, 2018
1 parent fde9cfc commit 4668f62
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion Changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@
- Swap default Docker environment from production to development, to improve DX.
- Eliminate production-mode inclusion of devDependencies, to keep production Docker image as light as possible and lower production-mode memory usage.
- Explicitly volume-map all files into Docker container when in dev-mode.
- Restore mongodb port mapping, for test suite (temporary - this should be removed once the test suite properly uses an in-memory mock db).
- Removed the --harmony-proxies flag from npm test, as it is no longer supported by nodejs.
- Eliminate different markup warning between client/server during dev
2 changes: 0 additions & 2 deletions docker-compose-production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ services:
MONGO_URL: mongodb://db:27017/mern-starter
db:
image: mongo:latest
ports:
- "27017:27017"
volumes:
- dbdata:/data/db
volumes:
Expand Down
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@ services:
tty: true
db:
image: mongo:latest
ports:
- "27017:27017"
volumes:
- dbdata:/data/db
volumes:
Expand Down

0 comments on commit 4668f62

Please sign in to comment.