Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-8301] adds optional parameter to syncMessages #879

Merged
merged 9 commits into from
Feb 12, 2025
Merged

[MOB-8301] adds optional parameter to syncMessages #879

merged 9 commits into from
Feb 12, 2025

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Feb 11, 2025 •
edited by jira bot
Loading

🔹 Jira Ticket(s) if any

✏️ Description

This pull request adds optional parameter for placement ids to make use of optional parameter on the API call.

@evantk91 evantk91 marked this pull request as draft February 11, 2025 23:49
@evantk91 evantk91 marked this pull request as ready for review February 12, 2025 00:56
joaodordio
joaodordio approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@joaodordio joaodordio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶LGTM🐶

iterableapi/src/test/resources/embedded_payload_single_placement_id_0.json
}],
"text": [{
"id": "body",
"text": "CATS RULE!!!",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a dog person I can not let this one pass I'm sorry!

Ayyanchira
Ayyanchira requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to support not passing placementIds like before as well

iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt Show resolved Hide resolved
@evantk91 evantk91 requested a review from Ayyanchira February 12, 2025 17:28
Ayyanchira
Ayyanchira approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt Show resolved Hide resolved
@evantk91 evantk91 merged commit 66b6932 into master Feb 12, 2025
3 of 4 checks passed
@evantk91 evantk91 deleted the evan/MOB-8301-add-placement-id-to-sync-messages branch February 12, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

@joaodordio joaodordio joaodordio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evantk91 @joaodordio @Ayyanchira