Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve error #706

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Resolve error #706

merged 4 commits into from
Feb 28, 2024

Conversation

hani-iterable
Copy link
Contributor

@hani-iterable hani-iterable commented Feb 15, 2024

🔹 Jira Ticket(s) if any

✏️ Description

We've implemented a check to ensure the package manager is not null, preventing potential crashes.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e00f7ae) 61.58% compared to head (d23f0a0) 61.57%.

Files Patch % Lines
...com/iterable/iterableapi/IterableActionRunner.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage   61.58%   61.57%   -0.01%     
==========================================
  Files          75       75              
  Lines        4680     4684       +4     
  Branches      530      531       +1     
==========================================
+ Hits         2882     2884       +2     
- Misses       1501     1502       +1     
- Partials      297      298       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Much cleaner than before.
Thank you @hani-iterable

@Ayyanchira Ayyanchira merged commit 648a3d0 into master Feb 28, 2024
5 checks passed
@Ayyanchira Ayyanchira deleted the MOB-7611 branch February 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants