Check for SDK initialization #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
- Coverage 62.74% 62.70% -0.04%
==========================================
Files 75 75
Lines 4678 4687 +9
Branches 529 530 +1
==========================================
+ Hits 2935 2939 +4
- Misses 1444 1447 +3
- Partials 299 301 +2 ☔ View full report in Codecov by Sentry. |
Ayyanchira
approved these changes
Feb 9, 2024
| } | ||
|
|
||
| /** | ||
| * Disables the device from push notifications | ||
| */ | ||
| public void disablePush() { | ||
| IterablePushRegistrationData data = new IterablePushRegistrationData(_email, _userId, _authToken, getPushIntegrationName(), IterablePushRegistrationData.PushRegistrationAction.DISABLE); | ||
| IterablePushRegistration.executePushRegistrationTask(data); | ||
| if (checkSDKInitialization()) { |
| @@ -1110,20 +1123,20 @@ public void updateUser(@NonNull JSONObject dataFields, Boolean mergeNestedObject | |||
| * user email or user ID is set before calling this method. | |||
| */ | |||
| public void registerForPush() { | |||
| if (!checkSDKInitialization()) { | |||
| return; | |||
| if (checkSDKInitialization()) { | |||
evantk91
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description