Skip to content

TaskId unification #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

TaskId unification #898

wants to merge 40 commits into from

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Apr 29, 2025

Historically we had JobId/JobTaskId in HQ and TaskId in Tako. Last versions made simple bijection between them to avoid doing lookups. This PR unifies it completely, to avoid code duplication and better and unified outputs.

  • JobId and JobTaskId is moved to Tako
  • TaskId is now pair JobId/JobTaskId. For Tako it is still functionally opaque type, but it can provide better messages because it prints real task ID and not some huge number.
  • In HQ, when both job_id/job_task_id was used, it is replaced by direct usage of TaskId. JobId or JobTaskId is used in places when we need to know only job id or job task id, but not both.
  • Reimports Tako types in HQ was removed, HQ now uses Tako types directly; mainly TaskTakoId was removed and HQ directly uses tako::TaskId.

THIS NEEDS DATA LAYER TO BE MERGED!

@spirali
Copy link
Collaborator Author

spirali commented Apr 29, 2025

Note: It actually removes more lines than it adds, it seems large only because it contains unmerged data layer

@spirali spirali requested a review from Kobzol April 29, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant