-
Notifications
You must be signed in to change notification settings - Fork 30
Data layer #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data layer #896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through all the commits, it sort of makes sense to me from a high-level of view, although I of course couldn't scan every little change in a 4k diff :) I think that I found one memory leak, the rest are just nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the data age!
This is experimental version of data layer (direct data transfers between tasks).
Main missing parts:
Because of never-ending conflicts I want to merge in the current form.
Even we would eventually remove the data layer (That is relatively easy, as now the code fully separates data dependencies and task dependencies)
then it is still to worth to merge it as this set of commits contains various generic refactorings, fixes problems in scheduler, fixes problem in some tests.