Use MimeTypeGuesserInterface. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on our setup, and it works. Thanks @rosiel! |
ruebot
approved these changes
Jul 20, 2023
|
For the record, this fix was provided by @aOelschlager! Thank you! |
|
Thank you @aOelschlager! |
aOelschlager
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2235
Release pull requests, etc.)
Slack discussion: https://islandora.slack.com/archives/CM5PPAV28/p1689795239307959
What does this Pull Request do?
Fixes a WSOD-causing typo(?). Use MimeTypeGuesserInterface rather than MimeTypesInterface.
What's new?
(i.e. Regeneration activity, etc.)?
How should this be tested?
Set up an islandora with some content that uses openseadragon.
Be on Openseadragon's 2.x branch, (HEAD, not the latest release) go to an opensedragon-y content page, and it'll whitescreen.
Pull this change, and it should behave normally again.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
@ruebot and @Islandora/committers