Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Crayfish-Commons #936

Merged
merged 7 commits into from
Apr 27, 2023
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Apr 19, 2023

GitHub Issue: Islandora/documentation#2220
Resolves: Islandora/Crayfish-Commons#59

This PR relies on:

What does this Pull Request do?

With the separation of the EntityMapper out into its own library, this PR removes the dependency on Crayfish-Commons.
It also handles some deprecations I ran across while doing this work.

What's new?

  • Remove crayfish-commons and adds chullo and islandora-fedora-entity-mapper to the composer.json.

  • Updates namespaces where necessary.

  • Adds a Fedora Flysystem logger to inject to the container.

  • Replaces deprecated \Symfony\Component\HttpFoundation\File\Mimetype\MimeTypeGuesserInterface with \Symfony\Component\Mime\MimeTypeGuesserInterface

  • Does this change add any new dependencies? yes islandora-fedora-entity-mapper and chullo (though both were originally part of or pulled in by crayfish-commons)

  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no

  • Could this change impact execution of existing code? If you are using another part of crayfish-commons, but I'm not sure what that would be

How should this be tested?

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@whikloj whikloj marked this pull request as ready for review April 27, 2023 14:56
@seth-shaw-asu seth-shaw-asu merged commit 3ef2f10 into 2.x Apr 27, 2023
@whikloj whikloj deleted the upgrade-crayfish-commons branch April 27, 2023 16:40
@whikloj whikloj restored the upgrade-crayfish-commons branch April 28, 2023 16:05
@rosiel rosiel deleted the upgrade-crayfish-commons branch June 28, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Conflict with Drupal LDAP module
2 participants