Remove dependency on Crayfish-Commons #936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2220
Resolves: Islandora/Crayfish-Commons#59
This PR relies on:
What does this Pull Request do?
With the separation of the EntityMapper out into its own library, this PR removes the dependency on Crayfish-Commons.
It also handles some deprecations I ran across while doing this work.
What's new?
Remove
crayfish-commons
and addschullo
andislandora-fedora-entity-mapper
to the composer.json.Updates namespaces where necessary.
Adds a Fedora Flysystem logger to inject to the container.
Replaces deprecated
\Symfony\Component\HttpFoundation\File\Mimetype\MimeTypeGuesserInterface
with\Symfony\Component\Mime\MimeTypeGuesserInterface
Does this change add any new dependencies? yes islandora-fedora-entity-mapper and chullo (though both were originally part of or pulled in by crayfish-commons)
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? If you are using another part of crayfish-commons, but I'm not sure what that would be
How should this be tested?
Documentation Status
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers