Only cache terms that exist (Islandora#2272)

Islandora · Jul 30, 2024 · dcbddf3 · dcbddf3
1 parent 579e056
commit dcbddf3
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/IslandoraUtils.php b/src/IslandoraUtils.php
@@ -311,15 +311,14 @@ public function getTermForUri($uri) {
     if (!empty($results)) {
       $term = $this->entityTypeManager->getStorage('taxonomy_term')
         ->load(reset($results));
+      $this->cache->set(
+        $cid,
+        $term,
+        CacheBackendInterface::CACHE_PERMANENT,
+        Cache::mergeTags(array_merge($term->getCacheTags(), ['user:' . $this->currentUser->id()]))
+      );
     }
 
-    $this->cache->set(
-      $cid,
-      $term,
-      CacheBackendInterface::CACHE_PERMANENT,
-      Cache::mergeTags(array_merge($term->getCacheTags(), ['user:' . $this->currentUser->id()]))
-    );
-
     return $term;
   }