Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Drupal 10. #105

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Use Drupal 10. #105

merged 7 commits into from
Jul 28, 2023

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Jul 21, 2023

Launch site with Drupal 10.

  • Updates the drupal version to 10.1
  • Adds config_update and context at non-stable versions
  • updates Drush
  • Removes the limiter to only install components compatible with (deprecated) PHP 7.4.

Note: Drush 12 "doesn't work with the launcher" so after an update (at least) you need to invoke it with vendor/bin/drush rather than just drush. This is annoying but I don't know how to remedy it, or if it's a starter-site problem or isle-site-template problem.

@rosiel rosiel marked this pull request as draft July 21, 2023 15:29
@rosiel
Copy link
Contributor Author

rosiel commented Jul 21, 2023

Draft until we sort out the HEADER_X_FORWARDED_ALL is deprecated thing in the site template.

@rosiel
Copy link
Contributor Author

rosiel commented Jul 21, 2023

Also, we need Matomo to fix this known issue where it can't install from existing configs because as of Drupal 10.1, the user module doesn't get installed first and so user roles aren't available in modules' install functions. Explanation. Ticket in matomo.

@rosiel rosiel marked this pull request as ready for review July 21, 2023 17:02
@rosiel rosiel marked this pull request as draft July 21, 2023 17:02
@rosiel rosiel marked this pull request as ready for review July 27, 2023 14:24
@rosiel
Copy link
Contributor Author

rosiel commented Jul 28, 2023

Draft until we sort out the HEADER_X_FORWARDED_ALL is deprecated thing in the site template.

I've isolated the error messages to a line in the Site Template, and created an issue and a pull request Islandora-Devops/isle-site-template#7.

@rosiel
Copy link
Contributor Author

rosiel commented Jul 28, 2023

The associated PR mentioned above has been merged, so this is now good for testing/merging.

Copy link
Contributor

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test works:

  1. Empty site template, used the PR branch.
  2. docker compose --profile dev up -d
  3. Inside the docker drupal container:
    1. composer install
    2. Update the settings.php according to the instructions
    3. Cleared cache

Drupal status page shows Drupal 10 and I can add new items with media. 👍

Anything else we need to do before merging?

@seth-shaw-asu seth-shaw-asu merged commit 768cfc4 into Islandora-Devops:main Jul 28, 2023
2 checks passed
@rosiel rosiel deleted the d10 branch March 1, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants