Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vkma to 3.2.0 #48

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Update vkma to 3.2.0 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d70400
Update vkma submodule
Ishan09811 Jan 2, 2025
844c5a1
memory_manager: ``VMA_MEMORY_USAGE_CPU_ONLY`` is deprecated
Ishan09811 Jan 3, 2025
9bd6d67
memory_manager: VMA_MEMORY_USAGE_GPU_ONLY is also deprecated
Ishan09811 Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/libraries/vkma
Open in desktop
Submodule vkma updated 267 files
5 changes: 3 additions & 2 deletions app/src/main/cpp/skyline/gpu/memory_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ namespace skyline::gpu::memory {
};
VmaAllocationCreateInfo allocationCreateInfo{
.flags = VMA_ALLOCATION_CREATE_MAPPED_BIT,
.usage = VMA_MEMORY_USAGE_CPU_ONLY,
.requiredFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,
.preferredFlags = VK_MEMORY_PROPERTY_HOST_CACHED_BIT, // may increase performance
};

VkBuffer buffer;
Expand Down Expand Up @@ -119,7 +120,7 @@ namespace skyline::gpu::memory {

Image MemoryManager::AllocateImage(const vk::ImageCreateInfo &createInfo) {
VmaAllocationCreateInfo allocationCreateInfo{
.usage = VMA_MEMORY_USAGE_GPU_ONLY,
.requiredFlags = VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT,
};

VkImage image;
Expand Down
Loading