Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main marco #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcoayora
Copy link

No description provided.

@sh-ih
Copy link

sh-ih commented Oct 23, 2023

Keep up the good work!

Some comments:

On the question that asked you to find all numbers divisible from 1 to 1000 by 7 you didn’t use the complete condition. That’s why it gave you all the numbers: instead of i/7, you needed to use the modulus: i%7==0

On the question ‘Convert the numbers of the following nested list to floats. Use floats as the name of the list.’, you left the numbers as strings. You needed to add the conversion to the comprehension list:

floats = [float(i) for row in list_of_lists for i in row]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants