Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chunk border rendering #2463

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

Plastoid501
Copy link
Contributor

fix #2125. I didn't know where to put the file, so I put it under net/irisshaders/iris/mixin. I would appreciate it if you could move it to an appropriate location.

@IMS212
Copy link
Member

IMS212 commented Aug 30, 2024

Would it be possible to add comments explaining what these do?

@Plastoid501
Copy link
Contributor Author

Plastoid501 commented Aug 30, 2024

Normally, overlapping lines make the line drawn later visible. In this case, however, the first line was visible. So I deleted the unwanted line drawn at the beginning of the overlapping lines. The isCameraChunk and isSubChunk methods make the red vertical line and the blue SubChunkBorder line correctly visible.

@Plastoid501
Copy link
Contributor Author

Plastoid501 commented Aug 30, 2024

The process of the @.Slice part is isCameraChunk, which draws red vertical lines in the corners of a 3x3 chunk centered on the chunk with the camera, and isSubChunk, which draws yellow lines every 2 blocks and dark cyan lines every 8 blocks. So isCameraChunk cancels the process of drawing the corners of the chunk with the camera, and isSubChunk cancels the process of drawing the borders of the subchunks every 16 blocks.

@IMS212
Copy link
Member

IMS212 commented Sep 9, 2024

Can you rebase this onto multiloader-new?

@Plastoid501
Copy link
Contributor Author

Plastoid501 commented Sep 10, 2024

Sorry, I must have made a mistake with the rebase. I don't know how to fix it, so should I change the branch to multiloader-new and Pull Request it again? I am so sorry.

@fayer3
Copy link
Contributor

fayer3 commented Sep 13, 2024

you need to change the target branch in the PR
click on edit in the top right, and change the base branch

@Plastoid501 Plastoid501 changed the base branch from 1.20.3 to multiloader-new September 15, 2024 10:56
@Plastoid501
Copy link
Contributor Author

Is this correct? Sorry for the disturbance.

@fayer3
Copy link
Contributor

fayer3 commented Sep 15, 2024

looks fine to me now

@IMS212 IMS212 merged commit b6dc6ad into IrisShaders:multiloader-new Sep 21, 2024
@IMS212
Copy link
Member

IMS212 commented Sep 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subchunk outline
4 participants