Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlite upgrade 3.38.0 #93

Closed

Conversation

herberteuler
Copy link
Contributor

@herberteuler herberteuler commented Mar 10, 2022

This change upgrades the embedded SQLite to version 3.38.0, which supports the new -> and ->> operators, and is required for Selda's JSON support on the SQLite backend.

Most of the tests passed, except this one mentioned in #92. I have removed the case, as the behavior after a failed table creation is undocumented, and the other aspects of the case are already covered by the earlier cases.

I have also bumped the version to 2.3.27, if that is appropriate.

@symbiont-haris-amin
Copy link

What would it take for this get merged and with a bump on direct-sqlite ? Would love to help out and speed it along if I can.

@herberteuler
Copy link
Contributor Author

I am not used to the release process. However, I have updated the version of its embedded SQLite, and all tests have passed. The tests of selda-sqlite have also passed with the new code as a dependency. What do we usually do for a new release at this stage?

@herberteuler
Copy link
Contributor Author

Ping @sigrlami

@herberteuler
Copy link
Contributor Author

Ping @IreneKnapp

@jchia
Copy link
Collaborator

jchia commented Jun 1, 2022

@herberteuler Thanks. I have separately updated to 3.38.5 but used one of your commits.

@jchia jchia closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants