add withDatabase, withStatement #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2023 22:18
jchia
requested changes
Jan 13, 2024
|
Hi, do I understand correctly my contribution was rejected because you
didn't like the commit message?
You do realize it's possible to rewrite those with a squash merge?
…On Tue, 23 Jan 2024 at 03:51, Joshua Chia ***@***.***> wrote:
Closed #104 <#104>.
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNBDKGKRK6A55FXKXFRBDDYP4QRJAVCNFSM6AAAAABAX25OY6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGU3DIMRWGAYDOOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I didn't really reject the PR. I have pushed the commits myself with updated commit messages as you can see, to quickly close loose ends. I don't know how to change someone's PRs or whether it is even generally possible, as the GitHub UI does not make it obvious.
|
|
A merge resulting in no additional commits and no difference to the commit history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a couple handy brackets