Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use region landmark for cells #69

Merged
merged 3 commits into from
Jun 29, 2023
Merged

use region landmark for cells #69

merged 3 commits into from
Jun 29, 2023

Conversation

tonyfast
Copy link
Contributor

a conversation in a11y slack made indicated that the form is being used as an anchor, not a landmark. this change:

  • makes the cell an explicit region while maintaining the feed pattern
  • removes the form label

@tonyfast
Copy link
Contributor Author

this approach with be more reliable across screen readers, and what i was doing before was inconsistent

ref: https://www.scottohara.me/blog/2019/04/05/landmarks-exposed.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant