Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant Import #284

Merged
merged 13 commits into from
Mar 5, 2019
Merged

Variant Import #284

merged 13 commits into from
Mar 5, 2019

Conversation

landswellsong
Copy link
Member

relevant last years commits minus hotfixes and FFT

Temporary countermeasure against #256
@elpiankova
Copy link
Member

Fixed #262

Copy link
Member

@elpiankova elpiankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works now. We can make new issue for quicklooks. @landswellsong, I'm ready to press "Approve"

@landswellsong
Copy link
Member Author

Ugh so press it :D

backend/promis/classes/variant.py Outdated Show resolved Hide resolved
backend/promis/export.py Show resolved Hide resolved
backend/promis/classes/base_data.py Outdated Show resolved Hide resolved
backend/promis/classes/variant.py Show resolved Hide resolved
backend/promis/orbit.py Outdated Show resolved Hide resolved
backend/promis/classes/variant.py Outdated Show resolved Hide resolved
backend/promis/classes/variant.py Show resolved Hide resolved
backend/promis/classes/variant.py Outdated Show resolved Hide resolved
backend/promis/classes/base_data.py Outdated Show resolved Hide resolved
backend/promis/orbit.py Outdated Show resolved Hide resolved
backend/promis/classes/base_data.py Outdated Show resolved Hide resolved
backend/promis/classes/variant.py Show resolved Hide resolved
# TODO: check that directory exists properly
# TODO: any more elegant way? re-yield or smth
for v in ftp.check():
yield v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landswellsong Объяснишь, что ты имел в виду про "элегантный вид"

Copy link
Member

@elpiankova elpiankova Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@landswellsong Леша, если можешь объясни нам этот TODO

backend/promis/classes/variant.py Outdated Show resolved Hide resolved
frontend/app/components/CesiumMap.js Show resolved Hide resolved
backend/promis/export.py Outdated Show resolved Hide resolved
@gloriajjl
Copy link
Contributor

перевірила CesiumMap - в point[2] щось приходить

Copy link
Member

@elpiankova elpiankova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Вперед к другим задачам:) Один TODO про ftp я отметила, чтоб спросить у Леши. Если что тоже откроем новое issue

@elpiankova elpiankova merged commit 208fd8e into dev Mar 5, 2019
@elpiankova elpiankova mentioned this pull request Mar 19, 2019
@elpiankova elpiankova deleted the variant_import branch June 18, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants