Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157.
Hi, thanks for the awesome product!
As pointed out in the issue #157, some type errors occur when you use scrape-it with TypeScript. That's because this product does not include
@types/cheerio
in dependencies. Moreover, old definitions in@types/cheerio
are used inlib/index.d.ts
so that installing the latest@types/cheerio
does not help.To reproduce the errors, you just need to:
npm ci
and do nothing else./lib
is imported.Here I made some changes:
@types/cheerio
lib/index.d.ts
I confirmed that these changes successfully pass a simple build task without errors.
There will be other ways to fix the issue, such as making some changes to use the latest cheerio (officially typed!) instead of installing
@types/cheerio
. That will be fine, but I think my proposal is the easiest way to fix the problem.