Feat: Funding Pot #741
Feat: Funding Pot #741
Conversation
| } | ||
|
|
||
| if (block.timestamp > round_.roundStart) { | ||
| revert Module__LM_PC_FundingPot__RoundAlreadyStarted(); |
There was a problem hiding this comment.
A bit of a nitpick, but since this will also trigger if somebody tries to edit an already finished round, maybe we can change the name (or add an extra error if size allows for it?)
There was a problem hiding this comment.
I can't really come up with a more descriptive error since the idea is that the admin can edit as long as a round hasn't started. Imo the error exactly tells this story.
There was a problem hiding this comment.
Yeah, fair. My comment came from the thought of "if a round started and ended, it's weird to revert saying 'it started' ". But it makes sense, the condition is "rounds are editable before start". Let's leavi it like that.
fabianschu
force-pushed
the
feat/funding-pot
branch
from
f8d3200 to
8dda04f
Compare
| } | ||
|
|
||
| if (block.timestamp > round_.roundStart) { | ||
| revert Module__LM_PC_FundingPot__RoundAlreadyStarted(); |
There was a problem hiding this comment.
Yeah, fair. My comment came from the thought of "if a round started and ended, it's weird to revert saying 'it started' ". But it makes sense, the condition is "rounds are editable before start". Let's leavi it like that.
No description provided.