Skip to content

[AUDIT] Feature: CrossChain PP Base & Everclear CrossChain PP #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
87e81f9
Crosschain PP Contract addition - DRAFT (#686)
leeftk Dec 5, 2024
ee8b480
Fix array orderring mismatch bug
0xNuggan Jan 15, 2025
cf5bb7b
address _setFlags() comment
0xNuggan Jan 15, 2025
198c386
address PaymentRouter comment
0xNuggan Jan 15, 2025
cecc3a2
fix review comments
0xNuggan Jan 16, 2025
a029f51
Fix: Revert to integer-based order ID (#707)
marvinkruse Jan 13, 2025
b6007f8
Merge branch 'audit-payment-order-struct' of https://github.com/Inver…
marvinkruse Jan 16, 2025
b887853
Fix: Resolve typos
marvinkruse Jan 16, 2025
f17b4c5
gas optimization in "_setFlags"
0xNuggan Jan 27, 2025
720e886
improve flag setting UX
0xNuggan Feb 5, 2025
e3a488f
bugfix
0xNuggan Feb 5, 2025
56d78fc
Add Valid Payment Order check to ProcessPayments
0xNuggan Feb 5, 2025
2b6ebcc
FIx: Move to stable version of Foundry
marvinkruse Jan 28, 2025
a82ccaf
Merge branch 'audit-dev-pre' into audit-payment-order-struct
marvinkruse Feb 7, 2025
680e3e6
Merge branch 'dev' into audit-payment-order-struct
0xNuggan Feb 10, 2025
dbaf6f2
contract renaming to V2
0xNuggan Feb 10, 2025
64892d5
Merge branch 'dev' into feature/crosschain-paymentProcessor
Zitzak Feb 19, 2025
2f757a5
Merge branch 'audit-payment-order-struct' into feature/crosschain-pay…
Zitzak Feb 19, 2025
e115a3f
Merge branch 'dev' into feature/crosschain-paymentProcessor
Zitzak Apr 9, 2025
7408565
fix: merge conflict
Zitzak Apr 9, 2025
591c1af
Feat: Everclear crosschain payment processor and base (#694)
leeftk Apr 9, 2025
d155a53
Refactor: update version
Zitzak Apr 9, 2025
70fd6af
fix: address review comment for PP_Everclear_CrossChain
Zitzak Apr 23, 2025
c01d4ca
fix: address review comment PP_CrossChainBase
Zitzak Apr 23, 2025
f4b7ede
Merge branch 'dev' into feature/crosschain-paymentProcessor
Zitzak Apr 24, 2025
d3d77c0
fix: resolve merge conflict
Zitzak Apr 24, 2025
438003f
refactor: resolve repo wide compiler warnings
Zitzak Apr 24, 2025
b48fd6d
Merge branch 'dev' into feature/crosschain-paymentProcessor
Zitzak Apr 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/logicModule/LM_PC_PaymentRouter_v2.sol
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ contract LM_PC_PaymentRouter_v2 is
function init(
IOrchestrator_v1 orchestrator_,
Metadata memory metadata,
bytes memory configData
bytes memory /* configData */
) external override(Module_v1) initializer {
__Module_init(orchestrator_, metadata);

Expand Down
2 changes: 1 addition & 1 deletion src/modules/logicModule/LM_PC_Staking_v2.sol
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ contract LM_PC_Staking_v2 is

/// @dev Ensures that the duration in seconds is larger than 0.
/// @param duration The duration of the reward period.
function _ensureValidDuration(uint duration) internal view {
function _ensureValidDuration(uint duration) internal pure {
if (duration == 0) {
revert Module__LM_PC_Staking_v2__InvalidDuration();
}
Expand Down
20 changes: 11 additions & 9 deletions src/modules/logicModule/interfaces/IERC20PaymentClientBase_v2.sol
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,17 @@ interface IERC20PaymentClientBase_v2 {
// MASTER LIST OF PAYMENT ORDER FLAGS

/*
| Flag | Variable type | Name | Description |
|------|---------------|------------|-------------------------------------|
| 0 | uint256 | orderID | ID of the order within the client. |
| 1 | uint256 | start | Start date of the streaming period. |
| 2 | uint256 | cliff | Duration of the cliff period. |
| 3 | uint256 | end | Due Date of the order |
| ... | ... | ... | (yet unassigned) |
| 255 | . | . | (Max Value). |
|------|---------------|------------|-------------------------------------|
| Flag | Type | Name | Description |
|------|---------|----------|------------------------------------|
| 0 | uint256 | orderID | ID of the order within the client |
| 1 | uint256 | start | Start date of the streaming period |
| 2 | uint256 | cliff | Duration of the cliff period |
| 3 | uint256 | end | Due Date of the order |
| 4 | uint256 | maxFee | Maximum fee |
| 5 | uint256 | TTL | Time-to-live |
| ... | ... | ... | (yet unassigned) |
| 255 | . | . | (Max Value) |
|------|---------|----------|------------------------------------|
*/

//--------------------------------------------------------------------------
Expand Down
Loading