Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft for k8s support #66

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jun 30, 2023

Description

Fix #133

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

…rfoil test enabled. Missing parts: docs (limitations and operators based + prerequisited), CI
@fabiobrz
Copy link
Member Author

/test all

@@ -51,29 +53,30 @@
*/
@Slf4j
@CleanBeforeAll
public class OperatorSubscriptionTestCase {
public class OpenShiftOperatorSubscriptionTestCase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no @OpenShiftTest on this one?

import lombok.extern.slf4j.Slf4j;

@Slf4j
public class Kubernetes extends DefaultKubernetesClient {
Copy link
Collaborator

@tommaso-borgato tommaso-borgato Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the Kubernetes client (io.fabric8.kubernetes.client.KubernetesClient) be provided through xtf?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this with the XTF team (@mnovak1, @simkam) and we agreed to start the implementation locally, then it could be moved in the future.

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

@fabiobrz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/intersmash-e2e dd43427 link true /test intersmash-e2e
ci/prow/prod-intersmash-e2e-prod dd43427 link true /test prod-intersmash-e2e-prod

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement K8s provisioning
2 participants